Test: Convert more tests to Swift Testing #8100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helpers related to the current platform to assist with conditionally running test cases.
Convert additional test from XCTest to Swift Testing to make use of parallel execution and, in some cases, test parameterization. Not all Test Suite in the respective folders have been converted as some use helpers in swift-tools-core-support, which don't have a matching swift testing helper.
bkhouri
changed the title
bkhouri
changed the title
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
Ready for review, though it may be blocked as not all pipeline builds run with Swift 6.0! |
Looks like the Selft-hosted macOS pipeline is now running the nightly build |
grynspan
reviewed
Nov 11, 2024
| @@ -43,17 +45,19 @@ final class SigningIdentityTests: XCTestCase { | |||
| _ = SwiftSigningIdentity(certificate: certificate, privateKey: Certificate.PrivateKey(privateKey)) | |||
|
|
|||
| // Test public API | |||
| XCTAssertNoThrow( | |||
| #expect(throws: Never.self) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert additional suites from XCTest to Swift Testing
Motivation:
The XCTest run, by default, sequentially. Convert some suites from XCTest to Swift Testing to make use of parallel execution and, in some cases, test parameterization.
Not all Test Suite in the respective folders have been converted as some use helpers in swift-tools-core-support, which don't have a matching swift testing helper.
Modifications:
Convert XCTest to Swift Testing
Result:
Ran the equivalent of the following and ensured there were no test-related failures
Depends on #8099