Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where test nondeterministically failed if SwiftPM doesn't return build settings quickly #1820

Merged
merged 1 commit into from
Nov 14, 2024
+8 −4
Merged

Fix issue where test nondeterministically failed if SwiftPM doesn't return build settings quickly #1820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Tests/SourceKitLSPTests/PublishDiagnosticsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,14 @@ final class PublishDiagnosticsTests: XCTestCase {
)

_ = try project.openDocument("FileB.swift")
let diagnosticsBeforeChangingFileA = try await project.testClient.nextDiagnosticsNotification()
XCTAssert(
diagnosticsBeforeChangingFileA.diagnostics.contains(where: { $0.message == "Cannot find 'sayHello' in scope" })
)
try await repeatUntilExpectedResult {
let diagnostics = try await project.testClient.nextDiagnosticsNotification()
if diagnostics.diagnostics.contains(where: { $0.message == "Cannot find 'sayHello' in scope" }) {
return true
}
logger.debug("Received unexpected diagnostics: \(diagnostics.forLogging)")
return false
}

let updatedACode = "func sayHello() {}"
let aUri = try project.uri(for: "FileA.swift")
Expand Down