Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn the user when debugging options are on #2278

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Jan 9, 2025

Closes #1270. When any debugging options are enabled, pop up a warning that progress will not be saved.

Note, in #1270, we discussed the possibility of saving progress even if --debug=creative is on, as long as creative mode is never actually engaged, but I'm not sure it's really worth going to that length. The warning should be enough.

@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Jan 9, 2025
@mergify mergify bot merged commit 54531b8 into main Jan 9, 2025
12 checks passed
@mergify mergify bot deleted the feature/refine-progress-saving branch January 9, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inform user when their progress/records will not be saved
2 participants