Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing cases to var usage analysis #2251

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Add missing cases to var usage analysis #2251

merged 2 commits into from
Dec 31, 2024

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Dec 30, 2024

Fixes #2250. Some term constructors (records, type annotations) were missing, but no one ever realized since there was a catch-all _ -> mempty case at the end. This PR:

  • adds the missing cases
  • adds some associated tests
  • explicitly enumerates the other non-variable cases so that in the future, when we add a new term constructor we will get a warning.

@byorgey byorgey requested review from kostmo and xsebek December 30, 2024 19:28
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Closed
@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Dec 31, 2024
@mergify mergify bot merged commit 4c8477d into main Dec 31, 2024
12 checks passed
@mergify mergify bot deleted the fix/issue-2250 branch December 31, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostmo kostmo kostmo approved these changes

@xsebek xsebek Awaiting requested review from xsebek

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect unused variable analysis
2 participants
@byorgey @kostmo