Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic cell modification #2247

Merged
merged 2 commits into from
Dec 29, 2024
Merged

generic cell modification #2247

merged 2 commits into from
Dec 29, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Dec 29, 2024

Makes the classifyModification function generic with type parameters, so that it can be moved "up" to the swarm-topography sublibrary.

@kostmo kostmo requested a review from byorgey December 29, 2024 07:05
@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Dec 29, 2024
@kostmo kostmo marked this pull request as ready for review December 29, 2024 07:05
byorgey
byorgey approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though it seems even more general than that - it is really just about classifying the ways any value changes, not just cells. I.e. it could live in swarm-util.

@kostmo
Copy link
Member Author

kostmo commented Dec 29, 2024

Looks good, though it seems even more general than that - it is really just about classifying the ways any value changes, not just cells. I.e. it could live in swarm-util.

Good point. I may consider merging Swarm.Game.Scenario.Topography.Modify and Swarm.Game.Scenario.Topography.Terraform in a follow up.

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Dec 29, 2024
@mergify mergify bot merged commit c0075cf into main Dec 29, 2024
12 checks passed
@mergify mergify bot deleted the refactor/generic-cell-modification branch December 29, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey