Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font is not clearly visible #469

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Bhoomidhanu12
Copy link

Pull Request Format

PR Title Font is not clearly visisble

Issue #429 : ISSUE NAME solved

Type of PR

  • Add X in the box to specify the improvement type.
  • Bug fix
  • [ *] Feature enhancement
  • Documentation update
  • Other (specify): ___________

Description

This pull request aims to [briefly describe what the pull request does, e.g., "add a new feature," "fix a bug," "improve documentation," etc.].

Screenshots / Videos (if applicable)

Before:

  • [Describe the state before the changes, e.g., "The section headings in the footer were misaligned, leading to an inconsistent and cluttered appearance."]

After:

  • [Describe the state after the changes, e.g., "The section headings in the footer are now properly aligned, providing a clean and professional look."]
    Screenshot (329)
    @swaraj-das

Checklist

  • Add X in the box to specify.
  • I have performed a self-review of my code.
  • [* ] I have tested the changes thoroughly before submitting this pull request.
  • [* ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [* ] I have commented my code, particularly in hard-to-understand areas.

Additional Context

[Provide any additional context about the changes, such as specific challenges you faced or decisions you made. This can help reviewers understand the rationale behind your changes.]

Thank you for reviewing my pull request!

I had make changes in the CSS code for clear apperance of fonts .
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
collect-your-gaming-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 0:49am

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for collect-your-gamingtools ready!

Name Link
🔨 Latest commit 51458cc
🔍 Latest deploy log https://app.netlify.com/sites/collect-your-gamingtools/deploys/670fb653f3f6740008e0dd35
😎 Deploy Preview https://deploy-preview-469--collect-your-gamingtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Bhoomidhanu12
Copy link
Author

@swaraj-das Once go through this PR

@swaraj-das
Copy link
Owner

@Bhoomidhanu12
image
you set the font color to white. If someone views it in light mode, how will they be able to read it?

@Bhoomidhanu12
Copy link
Author

Bhoomidhanu12 commented Oct 16, 2024

Screenshot (331)
@swaraj-das Ok then i will change the appropriate font color to both of the modes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants