Improvements #216
Open
Improvements #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. add mapping like NITY50 is Nifty 50 NIFTYFMCG is Nifty FMCG
Move to beautifulsoup4 version 4.9.1
Add it explicity via code
Requests to NSE were getting hanged and erroring out with timeout. Change the user agent header to what is working via firefox. Issue is resolved after changing the user agent
Delete the unnedded column only when its exists
Increase Nifty Options Strike price to 15000 Change Futures check to Aug 2021
Add holiday list from 2015 to 2021. Package the file in the pip package
dd holiday list to a static csv file. Parse the file. The Holiday URL is prone to failures. Since its published every year, its easy to maintain a file of holiday list
NSE had wrong entries. This is a hack to ignore those
Add tests to ensure all works as expected
NSE had wrong entries. This is a hack to ignore those
Calculate expiry dates in code
NSE js files for expiry dates has errors
EOD data not available for 2 May 2022. Treat it as a holiday
EOD data not available for 24 May 2022. Treat it as a holiday
Update holiday.csv
Update holiday.csv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.