Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add oauth config setting to enable/disable pkce extension #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PeterRodenkirchTNG
Copy link

Describe the PR
Add Proof Key for Code Exchange Support configurable with the OAuthConfig struct.

Relation issue
#99

Additional context
OAuth2 clients that only support Authorization Code Flow with PKCE do not work with the current feature set of echo-swagger.
There is a flag for it in Swagger UI 3.24.0+: usePkceWithAuthorizationCodeGrant and these small changes fix the problem.

@seilersTNG
Copy link

Hello, can you please consider reviewing and merging this PR. I think it is an important security feature that should be part of this library. Thank you. Best, Steffen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants