Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spec): validation errors formatting #9687

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Conversation

glowcloud
Copy link
Contributor

Supersedes #8333

@char0n
Copy link
Member

char0n commented Mar 13, 2024

@glowcloud could you transform your e2e test to unit test?

Unit test should be placed here: https://github.com/swagger-api/swagger-ui/blob/main/test/unit/core/plugins/spec/selectors.js

Justification: e2e tests are time expensive. If we can test things using unit tests, we should always prefer it.

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job!

@glowcloud glowcloud merged commit 99bf8fc into master Mar 13, 2024
8 checks passed
@glowcloud glowcloud deleted the validation-error-formatting branch March 13, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants