Allow passing args up to GenericNetlinkSocket constructor #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, most subclasses of GenericNetlinkSocket do not pass unused args up to GenericNetlinkSocket.__init__. One use case of this is to pass fileno= with an existing file descriptor that was opened in another process/network namespace. This patch fixes the following subclasses - EventSocket - NL80211 - DevlinkSocket - L2tp - WireGuard by passing up *args and **kwargs. We also fix TaskStats by simply removing the __init__ method that just calls super. We did not need to fix MPTCP and NlEthtool as they don't overwrite __init__.
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, most subclasses of GenericNetlinkSocket do not pass unused args up to GenericNetlinkSocket.init.
One use case of this is to pass fileno= with an existing file descriptor that was opened in another process/network namespace.
This patch fixes the following subclasses
by passing up *args and **kwargs.
We also fix TaskStats by simply removing the init method that just calls super.
We did not need to fix MPTCP and NlEthtool as they don't overwrite init.