Fix broken Number widget

Fix #282
sveltia · Dec 24, 2024 · bec46c1 · bec46c1
1 parent f1474f4
commit bec46c1
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -55,7 +55,7 @@
   "dependencies": {
     "@lexical/markdown": "^0.22.0",
     "@sindresorhus/transliterate": "^1.6.0",
-    "@sveltia/ui": "^0.22.1",
+    "@sveltia/ui": "^0.22.2",
     "@sveltia/utils": "^0.6.3",
     "deepmerge": "^4.3.1",
     "fast-deep-equal": "^3.1.3",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/lib/components/contents/details/widgets/number/number-editor.svelte b/src/lib/components/contents/details/widgets/number/number-editor.svelte
@@ -68,9 +68,15 @@
     // Avoid a cycle dependency & infinite loop
     if (currentValue !== undefined) {
       if (isNumeric && numInputValue !== currentValue) {
-        const value = Number(currentValue);
+        if (typeof currentValue === 'number') {
+          numInputValue = currentValue;
+        } else if (typeof currentValue === 'string') {
+          const value = currentValue.trim() ? Number(currentValue) : NaN;
 
-        numInputValue = !Number.isNaN(value) ? value : undefined;
+          numInputValue = !Number.isNaN(value) ? value : undefined;
+        } else {
+          numInputValue = undefined;
+        }
       }
 
       if (!isNumeric && strInputValue !== currentValue) {