Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video support added. #437

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Video support added. #437

wants to merge 3 commits into from

Conversation

engasix
Copy link

@engasix engasix commented Nov 24, 2022

SKPhotoBrowser is a beautiful tool which save million of lives, only thing which I was missing is the video support, I tried my level best to write code following the same footprint, I hope my pull request will be accepted and I will become part of the community

@engasix
Copy link
Author

engasix commented May 15, 2023

Waiting for being reviewed!

@tommyming
Copy link
Collaborator

@engasix sorry for the awaited late reply.

May I know the purpose of adding video support? Since this repository mainly provides photo browsing options.

Thanks and waiting for your reply!

@engasix
Copy link
Author

engasix commented Nov 22, 2024

@tommyming sorry for the late reply.

Modern galleries typically include both videos and images. If SKPhotoBrowser lacks video support, it risks falling behind. A content-based application cannot be considered complete without accommodating both media types.

Consider a scenario where a developer needs to display images and videos related to a specific post or event. Would SKPhotoBrowser be their choice without video support? The answer is likely no.

Thanks.

@tommyming
Copy link
Collaborator

@engasix thanks for the reply.

I understand what you mean, and how the scenario works.

But this repository is mainly for photo browsing, instead of media browsing.

But overall would be a nice to have. I will take a look to the PR later.

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants