Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3_informed_search #4

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

3_informed_search #4

wants to merge 8 commits into from

Conversation

pxouria
Copy link

@pxouria pxouria commented Oct 29, 2021

No description provided.

@@ -4,514 +4,281 @@
"cell_type": "markdown",
"metadata": {},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add table of contents!

@@ -4,514 +4,281 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"# Informed Search\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, let the title be

"\n",
"Informed search is an approach to solving problems with a start state to a goal state, that is based on some mathematical concepts that estimate our distance to a goal state and inform us about some of following states. \n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and rewriting an already written notebook made this reviewing process really hard for me, so thx :)))

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain this comment?
did I screw something up with GitHub?
apologies in advance.

]
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"![4](p4.png)"
"## A* Search\n",
Copy link

@sinatav sinatav Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make stronger connections between different parts of your notebook, don't jump from one topic to another make a suitable setup and a solid structure

"\n",
"• f(G_2)>f(G) from above\n",
"In the left diagram, the heuristic’s estimated cost value always (in all states) remains below the true cost value so h is admissible, however, in the right diagram, h sometimes overestimates the real cost value and violates admissibility condition.\n",
"The second and important condition on heuristic function, is Monotonicity or also called consistency. A heuristic function h(n) is monotonic, is consistent if, for every node n and every successor of n generated by any action a, the estimated cost of reaching the goal from n is no greater than the step cost of getting to plus the estimated cost of reaching the goal from n':\n",
Copy link

@sinatav sinatav Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review your grammar (for example the second and important)

"Where n = nodes the A* expands. It is obvious that if n is too big for main memory, n2 is too long to wait. To address this issue, we need to either change our heuristic function of A* algorithm steps. But there is another way! Another algorithm called SMA* or Simplified memory bounded A* is developed to circumvent the memory problem. In this algorithm, we define how much memory we have, and therefore how many nodes should be expanded. SMA* stores all expanded nodes and open the nodes in memory, and if the memory is full it deletes the leaf with highest f value and backs up the value in its parent. You can find an example of this algorithm in the pictures below:\n",
"\n",
"\n",
"![21](Picture21.png)"
]
Copy link

@sinatav sinatav Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write a brief conclusion or a summary as your outro :))

"Where n = nodes the A* expands. It is obvious that if n is too big for main memory, n2 is too long to wait. To address this issue, we need to either change our heuristic function of A* algorithm steps. But there is another way! Another algorithm called SMA* or Simplified memory bounded A* is developed to circumvent the memory problem. In this algorithm, we define how much memory we have, and therefore how many nodes should be expanded. SMA* stores all expanded nodes and open the nodes in memory, and if the memory is full it deletes the leaf with highest f value and backs up the value in its parent. You can find an example of this algorithm in the pictures below:\n",
"\n",
"\n",
"![21](Picture21.png)"
]
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add references

Copy link

@sinatav sinatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first review

@@ -4,514 +4,281 @@
"cell_type": "markdown",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your file should be .md and not .ipynb

"Where n = nodes the A* expands. It is obvious that if n is too big for main memory, n2 is too long to wait. To address this issue, we need to either change our heuristic function of A* algorithm steps. But there is another way! Another algorithm called SMA* or Simplified memory bounded A* is developed to circumvent the memory problem. In this algorithm, we define how much memory we have, and therefore how many nodes should be expanded. SMA* stores all expanded nodes and open the nodes in memory, and if the memory is full it deletes the leaf with highest f value and backs up the value in its parent. You can find an example of this algorithm in the pictures below:\n",
"\n",
"\n",
"![21](Picture21.png)"
]
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a "other useful links" section can be helpful

Copy link

@sinatav sinatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first review v2

@pxouria
Copy link
Author

pxouria commented Nov 11, 2021

Edited and uploaded index.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants