Fix memory leak in ipaddr.c #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlm
force-pushed
the
patch-3
branch
2 times, most recently
from
47744b1
to
393b41a
Compare
|
I wouldn't mess with dns.c as that's a third party library. If you want to upstream the patch, the repo is here: I've even filled a ticket about the problem: However, it looks like dns_ai_nextent just mallocs the item, so maybe the user is expected to free it manually and everything is working as expected. (The documentation is kind of lacking.) At the moment I would just add free(ent) statements to ipaddr.c wherever needed. |
|
Found a better way, check it out. |
vlm
force-pushed
the
patch-3
branch
2 times, most recently
from
c71cb6e
to
e926d64
Compare
vlm
commented
Mar 25, 2017
ipaddr.c
Outdated
| ipv6 = it; | ||
| it = NULL; | ||
| } | ||
| if(it) freeaddrinfo(it); /* Ended up useless */ |
There was a problem hiding this comment.
Note that unlike free(), freeaddrinfo() can't work on NULLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.