-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prometheus: keep all grafana functions under grafana flag #79
prometheus: keep all grafana functions under grafana flag #79
Conversation
6d4cd11
to
7ef63c0
Compare
It looks like the unit tests are all passing. so I'm marking this ready for review @SamYuan1990 I think this addresses your concerns from #77 |
main.sh
Outdated
return 0 | ||
} | ||
|
||
GOOS="$(go env GOOS)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golang is not pre installed in this repo, hence when integration on a new created ec2 instance, this will fail. Is there any possible to use uname to replace goarch? or install yq without golang/ or jq?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - I can get it to install without a golang dep - let me update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/mikefarah/yq?tab=readme-ov-file#wget maybe we can use curl or wget instead of golang? and add wget/curl with just apt/yum.
0b8450c
to
b477b84
Compare
Signed-off-by: Maryam Tahhan <[email protected]>
b477b84
to
96a63f8
Compare
Still updating this - will notify you when it's ready... [UPDATE] - works in local_dev_cluster from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and @maryamtahhan please create another PR, at https://github.com/sustainable-computing-io/local-dev-cluster/blob/main/main.sh#L125 changing the output message as hit to user and document.
Tested with local_dev_cluster using:
also tested with kepler by patching the local copy of the repo and running