-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): Add workflow for creating new release tag #55
feat(ci): Add workflow for creating new release tag #55
Conversation
Signed-off-by: Vibhu Prashar <[email protected]>
- name: Commit changes and tag it | ||
run: | | ||
git add VERSION | ||
git commit -m "ci: update VERSION to $VERSION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this commit -m breaks DCO check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it won't
tag_name: "v${{ github.event.inputs.tag }}" | ||
release_name: "v${{github.event.inputs.tag}}" | ||
draft: false | ||
prerelease: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a change log file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add it in the next PR
|
||
- name: Update the VERSION | ||
run: | | ||
echo "$VERSION" > VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, if we can use shell script to do a math function. for example read 0.0.3 from current file auto increases to 0.0.4 and commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, we can do that as well. But I wanted the version to be provided during runtime in cases where we want to break the continuous flow and maybe release something like 0.1.0
This PR adds a new workflow for creating releases