-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validator): add support to validate essential metrics produced by Kepler #1834
base: main
Are you sure you want to change the base?
feat(validator): add support to validate essential metrics produced by Kepler #1834
Conversation
🤖 SeineSailor Here is a concise summary of the pull request changes: Summary: This pull request introduces a new feature to validate Kepler metrics in the
Impact: These changes expand the Observations and Suggestions:
|
827aefd
to
564fa4c
Compare
|
||
validations: | ||
# absolute power comparison | ||
- name: Total - absolute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also validate these invariants in the same version of dev
- kepler_node_<pkg|core|uncore|dram|other>{dev} = sum of ( process_<pkg|core|uncore|dram|other>{dev} )
- kepler_node_<pkg|core|..> = node_exporter_rapl_<pkg|core...>
*sum( kepler_process_bpf_cpu ) = node_exporter_cpu_time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for kepler_node_<pkg|core|dram...>{dev} = sum of (process_<pkg|core|dram....>){dev}
do you mean
MAE of sum(rate(kepler_node<pkg|core|dram>){dev}[20s]) and sum(rate(process_<pkg|core|dram>{dev}[20s]))
?
click.secho(" * Generating validate metrics report file and dir", fg="green") | ||
write_md_report(results_dir, res) | ||
|
||
raise Exit(1) if not res.validations.passed else Exit(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just return 0 or 1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default when a Click script is invoked as command line application (through BaseCommand.main()) the return value is ignored unless the standalone_mode is disabled in which case it’s bubbled through.
https://click.palletsprojects.com/en/stable/commands/#command-return-values
33d2963
to
de1649f
Compare
…y Kepler This commit introduces functionality to validate essential metrics produced by Kepler The following comparisons are included: - Node Exporter Comparison - Validates `node_rapl_<package|core|dram>` metrics against `kepler_node_<package|core|dram>{dev}` - Kepler Process Comparison - Compares `kepler_process_<package|core|dram|platform|other|uncore>{latest}` metrics to `kepler_process_<package|core|dram|platform|other|uncore>{dev}` - Kepler Node Comparison - Validates `kepler_node_<package|core|dram|platform|other|uncore>{latest}` against `kepler_node_<package|core|dram|platform|other|uncore>{dev}` Additionally, a stressor script has been added to include system load, allowing for real-time validation of Kepler under stress conditions. Signed-off-by: vprashar2929 <[email protected]>
de1649f
to
5fa8028
Compare
This commit introduces functionality to validate essential metrics produced by Kepler
The following comparisons are included:
Node Exporter Comparison
node_rapl_<package|core|dram>
metrics againstkepler_node_<package|core|dram>{dev}
Kepler Process Comparison
kepler_process_<package|core|dram|platform|other|uncore>{latest}
metrics tokepler_process_<package|core|dram|platform|other|uncore>{dev}
Kepler Node Comparison
kepler_node_<package|core|dram|platform|other|uncore>{latest}
againstkepler_node_<package|core|dram|platform|other|uncore>{dev}
Additionally, a stressor script has been added to include system load, allowing for real-time validation of Kepler under stress conditions.