Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix estimate bug #128

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

Yanbo0101
Copy link
Contributor

This pr is to fix #127

Copy link
Contributor

@sunya-ch sunya-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for identifying the bug and make a fix.
The fix looks fine to me.
However, in my opinion, estimated results should be reported per each energy source.
If we want to estimate multiple energy sources at the same time. We should separate best result for each energy source.

If we want to keep one energy source, to fix the current bug, we can change only line 396 to [args.energy_source].

If we want to provide estimation for multiple energy sources at the same time, we need to move section save best result to energy source loop and save the file with prefix of the energy source.

Signed-off-by: Yanbo0101 <[email protected]>
@Yanbo0101
Copy link
Contributor Author

Thank you so much for identifying the bug and make a fix. The fix looks fine to me. However, in my opinion, estimated results should be reported per each energy source. If we want to estimate multiple energy sources at the same time. We should separate best result for each energy source.

If we want to keep one energy source, to fix the current bug, we can change only line 396 to [args.energy_source].

If we want to provide estimation for multiple energy sources at the same time, we need to move section save best result to energy source loop and save the file with prefix of the energy source.

Thanks for your comments. Fixed.

Copy link
Contributor

@sunya-ch sunya-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. /lgtm

@sunya-ch sunya-ch merged commit b4c9d3d into sustainable-computing-io:main Aug 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker run ... estimate ... failed
2 participants