bump version for local-dev-cluster to 0.0.3 #63
Conversation
SamYuan1990
commented
Aug 1, 2023
SamYuan1990
commented
- remove kubectl as GHA has kubectl
- bump to local dev cluster 0.0.3
- if there is cluster provider then ... use it avoid double running branch define.
index.js
Outdated
| parameterExport = parameterExport + "export KIND_VERSION="+kind_version; | ||
| parameterExport = parameterExport + " && " | ||
| } | ||
| } | ||
| parameterExport = parameterExport + "export CLUSTER_PROVIDER="+cluster_provider; |
There was a problem hiding this comment.
Do we need to have check if (parameterExport != ""). We are already assigning it value here. In any case it will not be empty
There was a problem hiding this comment.
maybe not? we have a default runner https://github.com/sustainable-computing-io/local-dev-cluster/blob/main/main.sh#L141
There was a problem hiding this comment.
In that case, also it will not make parameterExport empty. In the setup function, we are providing cluster_provider so when it comes to line 42 we are setting the value of parameterExport anyways. Why do we need checks at line 48, 58 and 68 ?
There was a problem hiding this comment.
aha, I got your point.
There was a problem hiding this comment.
@vprashar2929 I just update this PR with a fix. :-) please help review.
SamYuan1990
force-pushed
the
versionBumpUp
branch
from
760ed5c
to
2c0645c
Compare
SamYuan1990
force-pushed
the
versionBumpUp
branch
from
2c0645c
to
e603eda
Compare
Signed-off-by: Sam Yuan <[email protected]>
SamYuan1990
force-pushed
the
versionBumpUp
branch
from
e603eda
to
9751e7f
Compare
|
@rootfs , could you please help merge this PR? |
|
@SamYuan1990 Are we good to create a release as this PR is merged? |
