7.3.4 solving null format issue

surlabs · Aug 30, 2023 · ce445c1 · ce445c1
1 parent 7489436
commit ce445c1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/classes/class.assStackQuestion.php b/classes/class.assStackQuestion.php
@@ -1779,7 +1779,7 @@ public function initialiseQuestionFromSeed()
                         $error_message .= html_writer::tag('li', $key);
                     }
                     $s .= html_writer::tag('ul', $error_message);
-                    $this->question_text_instantiated .= $s;
+                    //$this->question_text_instantiated .= $s;
                 }
             }
 
@@ -1983,7 +1983,7 @@ public function isAnyPartInvalid(array $response): bool
         // Invalid if any input is invalid, ...
         foreach ($this->inputs as $name => $input) {
             if (stack_input::INVALID == $this->getInputState($name, $response)->status) {
-                $this->runtime_errors[] = $this->getInputState($name, $response)->errors;
+                //$this->runtime_errors[] = $this->getInputState($name, $response)->errors;
                 return true;
             }
         }
@@ -1992,7 +1992,7 @@ public function isAnyPartInvalid(array $response): bool
         foreach ($this->prts as $index => $prt) {
             $result = $this->getPrtResult($index, $response, false);
             if ($result->errors) {
-                $this->runtime_errors[] = $result->errors;
+                //$this->runtime_errors[] = $result->errors;
                 return true;
             }
         }

diff --git a/classes/class.assStackQuestionRenderer.php b/classes/class.assStackQuestionRenderer.php
@@ -161,7 +161,7 @@ public static function _renderQuestionText(assStackQuestion $question, bool $sho
                         $prt_state->set_cas_context($question->getSession(),$question->getSeed(),true);
                         $render = self::renderPRTFeedback($prt_state, $question);
                         if(strlen($render)){
-                            $prt_feedback .= self::renderPRTFeedback($prt_state, $question);
+                            $prt_feedback .= $render;
                         }else{
                             foreach ($prt_state->get_feedback() as $feedback){
                                 $prt_feedback .= $feedback->feedback;
@@ -703,6 +703,7 @@ public static function renderPRTFeedback(stack_potentialresponse_tree_state $prt
                 $format = '3';
             } else {
                 //$feedback .= $question->prt_partially_correct_instantiated . '<br>';
+                $format = '1';
             }
 
             //Substitute Variables in Feedback text

diff --git a/plugin.php b/plugin.php
@@ -6,7 +6,7 @@
 
 $id = "xqcas";
 
-$version = "7.3.2";
+$version = "7.3.4";
 
 $ilias_min_version = "7.13";
 $ilias_max_version = "7.999";