7.3.5 div by zero

surlabs · Sep 12, 2023 · a7d4bc3 · a7d4bc3
1 parent bd84c88
commit a7d4bc3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -93,7 +93,7 @@ composer du
 * The stable version 2.4.x for **ILIAS 5.2 to 5.3** is no longer maintained
 * The stable version 2.3.x for **ILIAS 5.0 to 5.1** is no longer maintained
 
-## Version 7.3.4 (2023.08.30)
+## Version 7.3.5 (2023.09.12)
 - JSXGraph inclusion
 - Rendering of JSXGraph blocks in STACK Questions
 - Binding of JSX elements to STACK inputs
@@ -102,7 +102,7 @@ composer du
 - Information message on MoodleXML Export regarding ILIAS Page content.
 - Solved issue when null format for specific feedback.
 - Solved #36722 Input type String changes to Algebraic input
-
+- Question having PRT with no points should now be properly rendered
 ## Version 7.2.10 (2023.07.17)
 - Solves #37393 Matrix Validation & Feedback in Tests
 - Solves #37318 Default feedback for locked answer view

diff --git a/classes/class.assStackQuestionDB.php b/classes/class.assStackQuestionDB.php
@@ -1433,7 +1433,11 @@ public static function _saveUserTestSolution(assStackQuestion $question, int $ac
 			//value1 = xqcas_input_*_status, $value2 = status
 			$obtained_points = (float)$question->getEvaluation()['points'][$prt_name]['prt_points'];
 			$max_prt_points = (float)$question->prts[$prt_name]->get_value();
-			$fraction = $obtained_points / $max_prt_points;
+            if ($max_prt_points != 0.0) {
+                $fraction = $obtained_points / $max_prt_points;
+            } else {
+                $fraction = 0.0;
+            }
 			$question->saveCurrentSolution($active_id, $pass, 'xqcas_prt_' . $prt_name . '_status', (string)$fraction);
 			$entered_values++;
 

diff --git a/plugin.php b/plugin.php
@@ -6,7 +6,7 @@
 
 $id = "xqcas";
 
-$version = "7.3.4";
+$version = "7.3.5";
 
 $ilias_min_version = "7.13";
 $ilias_max_version = "7.999";