Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: skip field validations on non signup routes #920

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

akashrajum7
Copy link
Contributor

@akashrajum7 akashrajum7 commented Aug 31, 2024

Summary of change

From my understanding of the ticket, we wanted to avoid doing field validations on form fields for non-signup routes, since it is field validation that emits FORM_FIELD errors. This would mean we would be delegating the validation to the core, for say email and password. Please feel free to let me know if this is not the intended change of the ticket and if it is to be done differently. I am quite new to the repo so my understanding is quite limited. I am happy to do it the right way with little guidance. Thank you for your time and patience.

Related issues

Test Plan

I have yet to run the test cases and update them if necessary, will do it once I get a go on the implementation

Documentation changes

This might need a Docs update as mentioned in the ticket.

Checklist for important updates

  • Changelog has been updated
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non-released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

  • Get clarification on the approach
  • Maybe update types where necessary (Need some guidance on this part as well)

Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for astounding-pegasus-21c111 canceled.

Name Link
🔨 Latest commit dab7d0c
🔍 Latest deploy log https://app.netlify.com/sites/astounding-pegasus-21c111/deploys/66d2f6114dbf87000899bcf9

Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for precious-marshmallow-968a81 canceled.

Name Link
🔨 Latest commit dab7d0c
🔍 Latest deploy log https://app.netlify.com/sites/precious-marshmallow-968a81/deploys/66d2f61164767f0008251026

@akashrajum7 akashrajum7 changed the title feat: skip field validations on non signup routes [WIP] feat: skip field validations on non signup routes Aug 31, 2024
@rishabhpoddar
Copy link
Member

Hey @akashrajum7 thanks for this PR. Whilst it makes sense, i won't be merging it right now, since this requires changes to our frontend sdk types and docs for which, we don't yet have the bandwidth.

@akashrajum7
Copy link
Contributor Author

Hey @akashrajum7 thanks for this PR. Whilst it makes sense, i won't be merging it right now, since this requires changes to our frontend sdk types and docs for which, we don't yet have the bandwidth.

Thanks for the review, sure, let me see if I can find some time this week to both update the test cases for these changes as well as make those changes in the frontend sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants