Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: library structulibrary structural changeral change #505

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

productdevbook
Copy link

@productdevbook productdevbook commented Mar 4, 2023

close #413
close #459
close #360
close #299

It includes major structural changes.

  • tsup build system
  • fix ts export paths again
  • eslint support
  • esm support
  • all dependencies update
  • test vitest change and ts convert
  • TS 4.9 support
  • TS 5.0 support
  • npm dist check. Check if they came out with the old structure exactly the same
  • pnpm 8.0.0 upgrade
  • ... soon

Test Errors
INSTALL_PATH=../supertokens-root pnpm test

  • thirdpartypasswordless/recipeFunctions
  • thirdpartypasswordless/provider
  • thirdpartypasswordless/smsDelivery
  • userroles/config
  • thirdparty/override
  • thirdparty/provider

* feat: pnpm

* delete package-lock

* fix: md

* Update CONTRIBUTING.md
* lib to src and tsup setup

* lib delete

* feat: tsup import

* export types

* Update test.ts

* fix: framework/request import

* fix: package.json

* delete recipe

* Update package.json
* feat: install lint

* Update .eslintrc

* fix: eslint problems

* fix: lint

* feat: ts 4.9 upgrade

* Revert "feat: ts 4.9 upgrade"

This reverts commit e70cf44.
@productdevbook
Copy link
Author

productdevbook commented Mar 4, 2023

upgrade "typescript": "^4.9.5"
and
pnpm build


recipe/emailverification/emailVerificationClaim.ts(48,3): error TS2612: Property 'validators' will overwrite the base property in 'BooleanClaim'. If this is intentional, add an initializer. Otherwise, add a 'declare' modifier or remove the redundant declaration.

If someone who is an expert on this issue solves the problem and sends me a pr, let's merge it here.

@productdevbook
Copy link
Author

productdevbook commented May 10, 2023

I waited for someone to fix 6 test errors, I wrote from discord, but no one came. So good luck with your project.

@rishabhpoddar
Copy link
Member

Apologies for not getting back sooner. We are quite busy with new feature releases.

About this PR, I think someone from our team was communicating with you earlier (on our discord). But due to the nature and size of the PR, we put that on hold.

If you can reduce the size of the PR or break it into smaller chunks, we would be happy to have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants