-
Notifications
You must be signed in to change notification settings - Fork 9
Update names of iPad devices... #19
base: master
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,17 @@ | |
require 'xclisten/shell_task' | ||
require 'listen' | ||
|
||
IOS_DEVICES = { | ||
# TODO Update iPhone names. | ||
'iphone5s' => 'iPhone Retina (4-inch 64-bit)', | ||
'iphone5' => 'iPhone Retina (4-inch)', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
||
'iphone4' => 'iPhone Retina (3.5-inch)', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
||
'ipad2' => 'iPad 2', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
||
'ipad_air' => 'iPad Air', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
||
'ipad_retina' => 'iPad Retina', | ||
'ipad_resizable' => 'Resizable iPad' | ||
} | ||
|
||
class XCListen | ||
|
||
attr_reader :device | ||
|
@@ -16,15 +27,6 @@ def initialize(opts = {}) | |
@device = IOS_DEVICES[opts[:device]] || IOS_DEVICES['iphone5s'] | ||
end | ||
|
||
IOS_DEVICES = { | ||
'iphone5s' => 'iPhone Retina (4-inch 64-bit)', | ||
'iphone5' => 'iPhone Retina (4-inch)', | ||
'iphone4' => 'iPhone Retina (3.5-inch)', | ||
'ipad2' => 'iPad', | ||
'ipad4' => 'iPad Retina', | ||
'ipad_air' => 'iPad Retina (64-bit)' | ||
} | ||
|
||
def workspace_path | ||
@workspace_path ||= Dir.glob("**/*.xcworkspace").sort_by(&:length).first | ||
end | ||
|
@@ -48,7 +50,7 @@ def install_pods | |
end | ||
|
||
def run_tests | ||
ShellTask.run("#{xcodebuild} test 2> xcodebuild_error.log | xcpretty -tc") | ||
ShellTask.run("#{xcodebuild} test 2>| xcodebuild_error.log | xcpretty -tc") | ||
end | ||
|
||
#TODO TEST THIS SPIKE | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.