-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sdk to 14 and related fixes #3444
base: develop
Are you sure you want to change the base?
Conversation
encodedUnknownTx is a spend tx with a tag replaced to 0xff
> Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.
Deployed to feature-update-sdk.wallet.z52da5wt.xyz, artifacts |
@@ -1,3 +1,5 @@ | |||
@use 'variables'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 8, column 8 of file:///Users/denis/Documents/superhero-wallet/src/styles/typography.scss:8:8:
Sass @ import rules are deprecated and will be removed in Dart Sass 3.0.0.
More info and automated migrator: https://sass-lang.com/d/import
@@ -4,7 +4,7 @@ import { STUB_ACCOUNT, STUB_TX_BASE_64 } from '@/constants/stubs'; | |||
|
|||
const callbackUrl = encodeURIComponent('http://localhost'); | |||
const encodedContractCallTx = encodeURIComponent('tx_+HQrAaEBbLQV9y00r/WCZ4XWrEVDpdiLPiLx2282rdKA1dkRTlmCA7yhBWuJbvnfcBIKpR/IbC+ywuM9P7fvmDFNerFKykCB+M1qA4al2v8FcAAAhzcV8VZnVACDGBf4hDuaygCQKxEV1igBG2+HI4byb8D/wPOLADU='); | |||
const encodedGaAttachTx = encodeURIComponent('tx_+O1QAaEByqPFadmQk4sGtyDiquosAZyKJNmherKOhheVIEYTLCITuIv4iUYDoIMndi6iAoqQltixF/3A6WlN0+rWVAan4LvFLy2pEJlhwLhcuDv+RNZEHwA3ADcAGg6CPwEDP/5s8lcLADcCFwcXdwAIPAIE+wNNTm90IGluIEF1dGggY29udGV4dAEBAJsvAhFE1kQfEWluaXQRbPJXCyVhdXRob3JpemWCLwCFNy4xLjAAoGzyVwsKFZm3CCkeUKo9rxPQx/JIS8M33a0kE6N/1KAJgwcAA4ZIjzqPaAAATIQ7msoAhysRRNZEHz+4yEN3'); | |||
const encodedUnknownTx = encodeURIComponent('tx_+FKB/wGhAcqjxWnZkJOLBrcg4qrqLAGciiTZoXqyjoYXlSBGEywioQHKo8Vp2ZCTiwa3IOKq6iwBnIok2aF6so6GF5UgRhMsIguGDyb1YcgAABOAFw87cw=='); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this test better to choose a completely broken transaction, to ensure that the wallet is forward-compatible.
The problem I had with GaAttachTx
is that currently, sdk rejects building such transactions with non-1 nonce.
nonce should be equal 1 if GaAttachTx, got 19 instead
currently it will fail only if I request to replace the signer
Tag, | ||
} from '@aeternity/aepp-sdk'; | ||
import { getHdWalletAccountFromSeed } from '@aeternity/aepp-sdk-13'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make a new release of sdk to fix that. Meanwhile, you can use it as is since tree shaking will remove the unused code.
This PR is supported by the Æternity Foundation
https://github.com/aeternity/aepp-sdk-js/blob/develop/docs/guides/migration/14.md