Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple aens claim and preclaim transactions #3159

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

CedrikNikita
Copy link
Collaborator

@CedrikNikita CedrikNikita commented Jul 10, 2024

This PR includes several improvements:

  • fixes Bug registering name #661;
  • fixes de-couple NamePreclaimTx and NameClaimTx in AENS claiming process #2200;
  • fixes Improve text on modals (nonce error) #2645;
  • user will no longer be able to preclaim exact the same name, while claiming name is in process (this currently results in infinite loading)
  • an account that claims a name will no longer be blocked from usage during claiming process. It took up to ~5 minutes. (all other transactions while the name was in the claiming process were accumulated in a pending state and were not executed until the name was claimed);
  • fixes an issue that caused the pointer to not be set to the current account if the user navigated off the page, closed the extension, and so on;
  • allows to claim several names one by one without any problems;
  • pending name now appears instantly, claimed name will also appear instantly in the wallet;
  • reduces the number of name check requests;

Copy link

@CedrikNikita CedrikNikita marked this pull request as draft July 10, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant