fix a bug in which a closing parenthesis in @graphql directive failed to parse as json #544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
If a comment directive had a closing parenthesis, it failed to parse as valid json. E.g.
comment on column table.column is e'@graphql({"description": "column description)"})';
would fail with errorinvalid input syntax for type json
What is the new behavior?
The comment directive parses as json successfully.
Additional context
The parsing failed because the regex in
graphql.comment_directive
function had a non-greedy match (.+?
). This terminated the search for an ending parenthesis early, resulting in an invalid json string. E.g. the following statement:returns
{"{\"description\": \"column description"}
. While the fixed regexp correctly returns{"{\"description\": \"column description)\"}"}
.