Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict Filtering List types to primary scalar elements #526

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Restrict Filtering List types to primary scalar elements #526

merged 6 commits into from
Jun 5, 2024

Conversation

olirice
Copy link
Contributor

@olirice olirice commented Jun 4, 2024 •
edited
Loading

What kind of change does this PR introduce?

  1. Restricts Filtering list types to primary scalar elements like String/Int/BigFloat

The main set we want to exclude are:

  • JSON/JSONB - these don't support equality
  • Opaque - its an unknown if they'll work and I'd prefer to keep simplicity rather than care about these
  • Enum - doesn't work out of the box and is a low priority feature
  • Composites - we don't support any composite filtering

  1. removes panic! when matching on filter op types

  2. Rename filter ops

  • renames ov to overlaps
  • rename cd to containedBy
  • rename cs to contains
  1. Remove filter ops gt, gte, lt, lte from list filtering options

resolves #523

@olirice olirice requested a review from imor June 4, 2024 16:50
@olirice olirice merged commit 8569ebb into master Jun 5, 2024
4 checks passed
@olirice olirice deleted the or/restrict-list-filters branch June 5, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imor imor imor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pg_graphql 1.5.5 - array with enum type - not working
2 participants
@olirice @imor