Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience coordinate methods to NDCube #709

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DanRyanIrish
Copy link
Member

PR Description

This PR adds 4 methods for getting the certain common coordinate types for all array indices of relevant axes:

  • NDCube.celestial
  • NDCube.time
  • NDCube.spectral
  • NDCube.stokes

These are convenience methods for NDCube.axis_world_coords. If the WCS does not contain the relevant axis, None is returned.

@DanRyanIrish DanRyanIrish added this to the 2.3.0 milestone May 25, 2024
@Cadair
Copy link
Member

Cadair commented May 25, 2024

I have many thoughts on this.

@DanRyanIrish DanRyanIrish modified the milestones: 2.3.0, 2.4.0 May 25, 2024
@DanRyanIrish
Copy link
Member Author

I have many thoughts on this.

I knew you would :) I look forward to them.

@DanRyanIrish
Copy link
Member Author

I have many thoughts on this.

@Cadair Would your thoughts be something more along the lines of #710 ?

@Cadair
Copy link
Member

Cadair commented May 26, 2024

Yes that's a starter.

@DanRyanIrish
Copy link
Member Author

Yes that's a starter.

Well if we can agree the API, at least for coords.celestial, coords.spectral and coords.time, we can push ahead with that and change the underlying implementation at a later time, as well as expand the API as desired.

Copy link

Hello 👋, Thanks for your contribution to ndcube!
I have marked this pull request as stale because there hasn't had any activity in five months. If you are still working on this, or if it's waiting on a maintainer to look at it then please let us know and we will keep it open. Please add a comment with: @sunpy/ndcube-developers to get someone's attention.
If nobody comments on this pull request for another month, it will be closed.

@github-actions github-actions bot added the stale label Oct 24, 2024
@github-actions github-actions bot removed the Stale label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants