Adds sunpy package template functionality #664
Conversation
.pre-commit-config.yaml
Outdated
| - id: mixed-line-ending | ||
| exclude: ".*(.fits|.fts|.fit|.header|.txt|tca.*)$" | ||
| - repo: https://github.com/codespell-project/codespell |
There was a problem hiding this comment.
Oh codespell didn't make it to the template?
.pre-commit-config.yaml
Outdated
| ci: | ||
| autofix_prs: false |
There was a problem hiding this comment.
This didn't either?
We should also disable updates if the plan is to roll them out via the template?
There was a problem hiding this comment.
We should add this to the template, asap.
We should also disable updates if the plan is to roll them out via the template?
hmm, this is a good and interesting question. Yes, we should roll out updates via the template, this would mean we go from one (pre-commit) to one (template update) auto PR rather than one to two. We should figure out how we can automate bumping the versions in the template though or they will surely get forgotten.
| ] | ||
|
|
||
| [project.urls] | ||
| repository = "https://docs.sunpy.org/projects/ndcube/" |
There was a problem hiding this comment.
We should expand these with docs and repository and homepage?
| @@ -1,30 +0,0 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
I thought this file had to stay?
There was a problem hiding this comment.
I'll stick it back in (first time using the interactive git add functoinality on kraken)
|
Looks like actions did not start? |
| @@ -1,3 +1,4 @@ | |||
| {% set default_python = '3.10' %} | |||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| core: | ||
| uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@v1 | ||
| uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@main |
There was a problem hiding this comment.
we should change the template to use v1 not main.
.pre-commit-config.yaml
Outdated
There was a problem hiding this comment.
When doing this manual retemplating we should keep all the extra stuff in files like this until it's updated in the template.
.pre-commit-config.yaml
Outdated
| ci: | ||
| autofix_prs: false |
There was a problem hiding this comment.
We should add this to the template, asap.
We should also disable updates if the plan is to roll them out via the template?
hmm, this is a good and interesting question. Yes, we should roll out updates via the template, this would mean we go from one (pre-commit) to one (template update) auto PR rather than one to two. We should figure out how we can automate bumping the versions in the template though or they will surely get forgotten.
| ] | ||
|
|
||
| [project.urls] | ||
| repository = "https://docs.sunpy.org/projects/ndcube/" |
|
Replaced by #672 |
Adds sunpy package template automation using cruft and cookiecutter
Removes some configuration files which would now duplicate functionality