Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sliceable MetaData Class #455
base: main
Are you sure you want to change the base?
Sliceable MetaData Class #455
Changes from 42 commits
ff9b13e
6d0d254
9166378
a2248c7
02cdcbb
eb57c05
96b8ab9
303320a
3cc208d
2b5d507
041cd1b
3bdf4a6
cd13518
ad88f5f
873d5b7
1d54ba3
f8c59ed
4611e1e
048e0ed
aa817fd
cf923f9
b0e21be
7df22e7
bbe6c12
86dc366
7160dc3
b3d439c
1f04d62
c27d904
8291189
5604de0
cdece82
51617e6
72bccb0
120596d
f3fc5a2
ad39c81
ad0e532
d01f6f6
d5ae2ef
181d86d
f17ba0b
da8df25
fb45151
9726b65
a626602
e848e9f
500843f
754385e
e8f9535
fef0de6
28eafbb
40b8b26
3ba2d9c
f723445
6d84e56
bf078bd
81b84e5
b526e3e
cdc3f8f
2373209
6d38c67
fb788f7
f315ca6
d81db9e
b59cbff
5776dca
5076384
bebcf1f
8127514
c4a83aa
d79a5e6
7f9f042
e35c34c
a58c705
944b0df
8f9816a
e0b9dbe
e4bdf03
ccf35dc
143afa1
aab969b
d1b4b47
1575a22
1845572
195fe19
672007e
baab449
39d675d
5c0e2cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 41 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L39-L41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
header
as the nomenclature withsunpy.map.Map
in mind. But this tends to imply a FITS header, which is over-specific. Perhaps this should be changed tometa
andoriginal_meta
. Thoughts @ayshih @Cadair?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favour of
meta
rather thanheader
Check warning on line 44 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L43-L44
Check warning on line 48 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L46-L48
Check warning on line 51 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L50-L51
Check warning on line 55 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L53-L55
Check warning on line 57 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L57
Check warning on line 60 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L59-L60
Check warning on line 62 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L62
Check warning on line 65 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L64-L65
Check warning on line 67 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L67
Check warning on line 69 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L69
Check warning on line 73 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L71-L73
Check warning on line 75 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L75
Check warning on line 84 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L79-L84
Check warning on line 89 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L87-L89
Check warning on line 91 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L91
Check warning on line 93 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L93
Check warning on line 95 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L95
Check warning on line 100 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L97-L100
Check warning on line 106 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L102-L106
Check warning on line 108 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L108
Check warning on line 112 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L112
Check warning on line 116 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L116
Check warning on line 120 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L120
Check warning on line 145 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L144-L145
Check warning on line 153 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L147-L153
Check warning on line 155 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L155
Check warning on line 162 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L158-L162
Check warning on line 170 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L165-L170
Check warning on line 175 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L174-L175
Check warning on line 178 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L178
Check warning on line 187 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L186-L187
Check warning on line 190 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L189-L190
Check warning on line 196 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L193-L196
Check warning on line 216 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L200-L216
Check warning on line 218 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L218
Check warning on line 220 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L220
Check warning on line 222 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L222
Check warning on line 230 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L225-L230
Check warning on line 233 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L232-L233
Check warning on line 239 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L235-L239
Check warning on line 242 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L242
Check warning on line 261 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L259-L261
Check warning on line 264 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L263-L264
Check warning on line 269 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L267-L269
Check warning on line 278 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L273-L278
Check warning on line 281 in ndcube/meta.py
Codecov / codecov/patch
ndcube/meta.py#L280-L281
Check warning on line 30 in ndcube/mixins/ndslicing.py
Codecov / codecov/patch
ndcube/mixins/ndslicing.py#L30
Check warning on line 1212 in ndcube/ndcube.py
Codecov / codecov/patch
ndcube/ndcube.py#L1211-L1212
Check warning on line 1214 in ndcube/ndcube.py
Codecov / codecov/patch
ndcube/ndcube.py#L1214