Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sliceable MetaData Class #455
base: main
Are you sure you want to change the base?
Sliceable MetaData Class #455
Changes from 18 commits
ff9b13e
6d0d254
9166378
a2248c7
02cdcbb
eb57c05
96b8ab9
303320a
3cc208d
2b5d507
041cd1b
3bdf4a6
cd13518
ad88f5f
873d5b7
1d54ba3
f8c59ed
4611e1e
048e0ed
aa817fd
cf923f9
b0e21be
7df22e7
bbe6c12
86dc366
7160dc3
b3d439c
1f04d62
c27d904
8291189
5604de0
cdece82
51617e6
72bccb0
120596d
f3fc5a2
ad39c81
ad0e532
d01f6f6
d5ae2ef
181d86d
f17ba0b
da8df25
fb45151
9726b65
a626602
e848e9f
500843f
754385e
e8f9535
fef0de6
28eafbb
40b8b26
3ba2d9c
f723445
6d84e56
bf078bd
81b84e5
b526e3e
cdc3f8f
2373209
6d38c67
fb788f7
f315ca6
d81db9e
b59cbff
5776dca
5076384
bebcf1f
8127514
c4a83aa
d79a5e6
7f9f042
e35c34c
a58c705
944b0df
8f9816a
e0b9dbe
e4bdf03
ccf35dc
143afa1
aab969b
d1b4b47
1575a22
1845572
195fe19
672007e
baab449
39d675d
5c0e2cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
header
as the nomenclature withsunpy.map.Map
in mind. But this tends to imply a FITS header, which is over-specific. Perhaps this should be changed tometa
andoriginal_meta
. Thoughts @ayshih @Cadair?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favour of
meta
rather thanheader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.