Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that invalid form returns http 422 status code #388

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

Jupi007
Copy link
Contributor

@Jupi007 Jupi007 commented Jun 22, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #383
License MIT

What's in this PR?

Return the correct http code (422), when an invalid form is submitted.

Why?

Using Hotwire Turbo and this bundle, submit a form with invalid value is causing problems : no error displayed and no redirection.

To Do

  • Add tests (I prefer to wait your approval on the way I implemented that) ;

@alexander-schranz alexander-schranz changed the title feat: invalid form returns http 422 Fix that invalid form returns http 422 Jul 24, 2024
@alexander-schranz alexander-schranz merged commit 92bb873 into sulu:2.5 Jul 24, 2024
8 checks passed
@alexander-schranz alexander-schranz changed the title Fix that invalid form returns http 422 Fix that invalid form returns http 422 status code Jul 24, 2024
@alexander-schranz
Copy link
Member

@Jupi007 Thank you!

@Jupi007 Jupi007 deleted the Jupi007/issue383 branch July 24, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid forms should return a HTTP 422 code
2 participants