Fix pipeline by updating PHPStan #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
December 12, 2022 14:03
Return typehint of method Sulu\Bundle\CommentBundle\Entity\CommentRepository::createNew() has invalid type Sulu\Component\Persistence\Repository\T
Parameter #1 $url of class Symfony\Component\HttpFoundation\RedirectResponse constructor expects string, float|int|string|true given.
Parameter #1 $message of method Sulu\Bundle\CommentBundle\Entity\CommentInterface::setMessage() expects string, bool|float|int|string|null given.
Parameter #1 $title of method Sulu\Bundle\CommentBundle\Entity\ThreadInterface::setTitle() expects string, bool|float|int|string|null given.
Parameter #2 $str of function explode expects string, float|int|string|true given.
Parameter excludes_analyse has been deprecated so use excludePaths only from now on
Ignored error #Symfony\\Contracts\\EventDispatcher\\EventDispatcherInterface::dispatch()# has an unescaped '()' which leads to ignoring all errors. Use '\(\)' instead.
Class Sulu\Bundle\CommentBundle\Entity\ThreadRepository extends generic class Doctrine\ORM\EntityRepository but does not specify its types: TEntityClass
Interface Sulu\Bundle\CommentBundle\Entity\CommentRepositoryInterface extends generic interface Sulu\Component\Persistence\Repository\RepositoryInterface but does not specify its types: T
PHPDoc tag @var for variable $commentFormToolbarActions has no value type specified in iterable type array.
StephenBeirlaen
changed the title
PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".
|
Thx for your PR, we did lot of changes and tackled also the different phpdocs and so we not longer have any PHPStan issues open. If you still stumble over something let us know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
I was interested in adding support for PHP8(.2). In preparation of doing that, phpstan can be updated.
I also noticed in the current pipeline that there were 9 errors on PHP 7.4. I first fixed all but one of these (one which I couldn't fix). Then I performed the update of phpstan and all related packages. After the update, a number of extra errors appeared (56).
I tried to fix the relatively low-hanging fruit, but was still left with 30 remaining errors that were put in the baseline.
Many of the errors put in the baseline are related to phpstan-doctrine not being able to infer the resulting type of the query, which causes
Method Sulu\Bundle\CommentBundle\Entity\CommentRepository::findComments() should return array<Sulu\Bundle\CommentBundle\Entity\CommentInterface> but returns mixed.. The main sulu/sulu also has this forSulu\Bundle\CategoryBundle\Entity\CategoryRepository::findCategories(), as an example.Another cause is some inconsistencies about fields being nullable or not:
??check. Not a check that feels safe to just remove.I would suggest that these can be fixed later?
Why?
To add support for PHP 8+