Skip to content

Commit

Permalink
Revert "Set the combined subtitle track as the default (used by Saf…
Browse files Browse the repository at this point in the history
…ari)"

This reverts commit dc72c6a.
  • Loading branch information
simonwiles committed Jun 6, 2024
1 parent 895c690 commit 1389060
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 11 deletions.
1 change: 0 additions & 1 deletion src/_layouts/popout.html
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@
track.setAttribute("src", src);
track.setAttribute("srclang", "en");
track.setAttribute("kind", "subtitles");
if (label === "Combined") track.setAttribute("default", true);
video.appendChild(track);
}
document.body.appendChild(video);
Expand Down
3 changes: 0 additions & 3 deletions webpack/__tests__/__snapshots__/play.spec.jsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -2161,23 +2161,20 @@ exports[`<Play> renders as expected 1`] = `
type="video/mp4"
/>
<track
default={false}
key="Translation"
kind="subtitles"
label="Translation"
src="/data/captions/kokaji.translation.vtt"
srcLang="en"
/>
<track
default={false}
key="Transcription"
kind="subtitles"
label="Transcription"
src="/data/captions/kokaji.transcription.vtt"
srcLang="en"
/>
<track
default={true}
key="Combined"
kind="subtitles"
label="Combined"
Expand Down
6 changes: 0 additions & 6 deletions webpack/__tests__/__snapshots__/section.spec.jsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -34553,23 +34553,20 @@ exports[`<Section> renders as expected 1`] = `
type="video/mp4"
/>
<track
default={false}
key="Translation"
kind="subtitles"
label="Translation"
src="/data/captions/kokaji.translation.vtt"
srcLang="en"
/>
<track
default={false}
key="Transcription"
kind="subtitles"
label="Transcription"
src="/data/captions/kokaji.transcription.vtt"
srcLang="en"
/>
<track
default={true}
key="Combined"
kind="subtitles"
label="Combined"
Expand Down Expand Up @@ -133253,23 +133250,20 @@ exports[`<Section> renders as expected with no phrases 1`] = `
type="video/mp4"
/>
<track
default={false}
key="Translation"
kind="subtitles"
label="Translation"
src="/data/captions/kokaji.translation.vtt"
srcLang="en"
/>
<track
default={false}
key="Transcription"
kind="subtitles"
label="Transcription"
src="/data/captions/kokaji.transcription.vtt"
srcLang="en"
/>
<track
default={true}
key="Combined"
kind="subtitles"
label="Combined"
Expand Down
1 change: 0 additions & 1 deletion webpack/components/MasterVideo.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class MasterVideo extends Component {
kind={track.kind}
srcLang={track.lang}
src={track.url}
default={track.label === "Combined"}
/>
));
}
Expand Down

0 comments on commit 1389060

Please sign in to comment.