Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LinkedList.java #831

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gursparsh
Copy link

Have you read the Contribution Guidelines?

Yes

Description

Added mid node function reference issue #827

Checklist

  • I've read the contribution guidelines.
  • I've checked the issue list before deciding what to submit.
  • I've edited the README.md and link to my code.

Related Issues (#827 )

Fixes Issue #827


(Write your answer above.)

Added mid node function reference issue sukritishah15#827


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gursparsh,
The code seems good.

Could you please call the function and add the sample input, output and time and space complexity as well?

If possible, could you add it for all the functions? (Let me know, if this is not convenient, I would take care of it later. )

Also, in the current version of this file, we have lines added due to merge conflicts, Line 1 for example. This seems to have crept in the code, while we were organizing the JAVA folder for the better, for this repository.
Could you please remove such lines from the file, in the next review?

Also, let me know, if you would like to contribute to more issues / repository (Maintainer) in future.

Thanks,
Sukriti

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure! I'll do all the necessary changes and add time complexity for all the functions.
I would be happy to contribute to more issues !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants