feat: residue test #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puma314
reviewed
Jun 29, 2024
| @@ -127,6 +127,25 @@ impl Fp12 { | |||
| Fp12 { c0, c1 } | |||
| } | |||
|
|
|||
| pub fn mul_by_034(&self, c0: &Fp2, c3: &Fp2, c4: &Fp2) -> Fp12 { | |||
There was a problem hiding this comment.
Can you add a /// comment on this function indicating what it does? Also why is it named "mul_by_034"?
src/fast_pairings.rs
Outdated
| @@ -0,0 +1,51 @@ | |||
| use crate::{fp12::Fp12, fp2::Fp2, G1Affine, G2Affine}; | |||
|
|
|||
| fn eval(f: &mut Fp12, lambda: Fp2, p1: &G1Affine, t_x: Fp2, t_y: Fp2) { | |||
There was a problem hiding this comment.
Would be good to have a few comments as to what is going on (and also relevant section of the pairings paper)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, verifying Tate pairings is expensive. For instance, the
final_exponentiationstep of an unreduced Tate pairing consists of vanishing the r-th roots of the image of the Tate pairing. Instead, we can use a Residue Test.