-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: residue test #1
base: main
Are you sure you want to change the base?
Conversation
@@ -127,6 +127,25 @@ impl Fp12 { | |||
Fp12 { c0, c1 } | |||
} | |||
|
|||
pub fn mul_by_034(&self, c0: &Fp2, c3: &Fp2, c4: &Fp2) -> Fp12 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a ///
comment on this function indicating what it does? Also why is it named "mul_by_034"?
src/fast_pairings.rs
Outdated
@@ -0,0 +1,51 @@ | |||
use crate::{fp12::Fp12, fp2::Fp2, G1Affine, G2Affine}; | |||
|
|||
fn eval(f: &mut Fp12, lambda: Fp2, p1: &G1Affine, t_x: Fp2, t_y: Fp2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have a few comments as to what is going on (and also relevant section of the pairings paper)
Currently, verifying Tate pairings is expensive. For instance, the
final_exponentiation
step of an unreduced Tate pairing consists of vanishing the r-th roots of the image of the Tate pairing. Instead, we can use a Residue Test.