fix: add better default value for metrics port (#35)

* add better default value for metrics port * edit changelog
subshell · Jan 15, 2024 · 4ba2db3 · 4ba2db3
1 parent b866eb2
commit 4ba2db3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.3.1 (2024-01-15)
+* improve configuration of metrics port
+
 ## 1.3.0 (2024-01-15)
 * allow serving metrics under a different port
 * update dependencies to latest versions

diff --git a/README.md b/README.md
@@ -37,7 +37,7 @@ oneko:
   catnipUrl:
   server:
     port: 8080
-    metricsPort:
+    metricsPort: 8080
   logging:
     level:
 ```

diff --git a/config/application-default.yaml b/config/application-default.yaml
@@ -8,7 +8,7 @@ oneko:
   catnipUrl:
   server:
     port: 8080
-    metricsPort:
+    metricsPort: 8080
   mode: production
   logging:
     level: 
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -141,5 +141,5 @@ const (
 
 type ServerConfig struct {
 	Port        int `yaml:"port" validate:"required,number"`
-	MetricsPort int `yaml:"metricsPort" validate:"number"`
+	MetricsPort int `yaml:"metricsPort" validate:"required,number"`
 }