Fix dictionary bigint #281

yoozo · 2024-08-22T08:10:47Z

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist

I have tested locally
I have performed a self review of my changes
Updated any relevant documentation
Linked to any relevant issues
I have added tests relevant to my changes
Any dependent changes have been merged and published in downstream modules
My code is up to date with the base branch
I have updated relevant changelogs. We suggest using chan

github-actions · 2024-08-22T08:13:37Z

Coverage report

Caution

Test run failed

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	42.81%	2276/5317
🟡	Branches	75.89%	299/394
🔴	Functions	50.84%	121/238
🔴	Lines	42.81%	2276/5317

Test suite run failed

Failed tests: 4/73. Failed suites: 2/8.

  ● Dictionary Queries › Message Filter Queries › Basic wasm filter works

    ApolloError: Response not successful: Received status code 500

      at new ApolloError (node_modules/@apollo/client/errors/index.js:40:28)
      at node_modules/@apollo/client/core/QueryManager.js:785:71
      at both (node_modules/@apollo/client/utilities/observables/asyncMap.js:22:31)
      at node_modules/@apollo/client/utilities/observables/asyncMap.js:11:72
      at Object.then (node_modules/@apollo/client/utilities/observables/asyncMap.js:11:24)
      at Object.error (node_modules/@apollo/client/utilities/observables/asyncMap.js:24:49)
      at notifySubscription (node_modules/zen-observable/lib/Observable.js:140:18)
      at onNotify (node_modules/zen-observable/lib/Observable.js:179:3)
      at SubscriptionObserver.error (node_modules/zen-observable/lib/Observable.js:240:7)
      at node_modules/@apollo/client/utilities/observables/iteration.js:7:68
          at Array.forEach (<anonymous>)
      at iterateObserversSafely (node_modules/@apollo/client/utilities/observables/iteration.js:7:25)
      at Object.error (node_modules/@apollo/client/utilities/observables/Concast.js:76:21)
      at notifySubscription (node_modules/zen-observable/lib/Observable.js:140:18)
      at onNotify (node_modules/zen-observable/lib/Observable.js:179:3)
      at SubscriptionObserver.error (node_modules/zen-observable/lib/Observable.js:240:7)
      at handleError (node_modules/@apollo/client/link/http/parseAndCheckHttpResponse.js:170:14)
      at node_modules/@apollo/client/link/http/createHttpLink.js:145:17

    Cause:
    ServerError: Response not successful: Received status code 500

      at Object.throwServerError (node_modules/@apollo/client/link/utils/throwServerError.js:2:17)
      at throwServerError (node_modules/@apollo/client/link/http/parseAndCheckHttpResponse.js:120:9)
      at node_modules/@apollo/client/link/http/parseAndCheckHttpResponse.js:176:48

  ● Dictionary Queries › Message Filter Queries › Wasm with contract filter builds a valid query

    ApolloError: Response not successful: Received status code 500

      at new ApolloError (node_modules/@apollo/client/errors/index.js:40:28)
      at node_modules/@apollo/client/core/QueryManager.js:785:71
      at both (node_modules/@apollo/client/utilities/observables/asyncMap.js:22:31)
      at node_modules/@apollo/client/utilities/observables/asyncMap.js:11:72
      at Object.then (node_modules/@apollo/client/utilities/observables/asyncMap.js:11:24)
      at Object.error (node_modules/@apollo/client/utilities/observables/asyncMap.js:24:49)
      at notifySubscription (node_modules/zen-observable/lib/Observable.js:140:18)
      at onNotify (node_modules/zen-observable/lib/Observable.js:179:3)
      at SubscriptionObserver.error (node_modules/zen-observable/lib/Observable.js:240:7)
      at node_modules/@apollo/client/utilities/observables/iteration.js:7:68
          at Array.forEach (<anonymous>)
      at iterateObserversSafely (node_modules/@apollo/client/utilities/observables/iteration.js:7:25)
      at Object.error (node_modules/@apollo/client/utilities/observables/Concast.js:76:21)
      at notifySubscription (node_modules/zen-observable/lib/Observable.js:140:18)
      at onNotify (node_modules/zen-observable/lib/Observable.js:179:3)
      at SubscriptionObserver.error (node_modules/zen-observable/lib/Observable.js:240:7)
      at handleError (node_modules/@apollo/client/link/http/parseAndCheckHttpResponse.js:170:14)
      at node_modules/@apollo/client/link/http/createHttpLink.js:145:17

    Cause:
    ServerError: Response not successful: Received status code 500

      at Object.throwServerError (node_modules/@apollo/client/link/utils/throwServerError.js:2:17)
      at throwServerError (node_modules/@apollo/client/link/http/parseAndCheckHttpResponse.js:120:9)
      at node_modules/@apollo/client/link/http/parseAndCheckHttpResponse.js:176:48

  ● Dictionary Queries › Message Filter Queries › Wasm with nested filter works

    ApolloError: Response not successful: Received status code 500

      at new ApolloError (node_modules/@apollo/client/errors/index.js:40:28)
      at node_modules/@apollo/client/core/QueryManager.js:785:71
      at both (node_modules/@apollo/client/utilities/observables/asyncMap.js:22:31)
      at node_modules/@apollo/client/utilities/observables/asyncMap.js:11:72
      at Object.then (node_modules/@apollo/client/utilities/observables/asyncMap.js:11:24)
      at Object.error (node_modules/@apollo/client/utilities/observables/asyncMap.js:24:49)
      at notifySubscription (node_modules/zen-observable/lib/Observable.js:140:18)
      at onNotify (node_modules/zen-observable/lib/Observable.js:179:3)
      at SubscriptionObserver.error (node_modules/zen-observable/lib/Observable.js:240:7)
      at node_modules/@apollo/client/utilities/observables/iteration.js:7:68
          at Array.forEach (<anonymous>)
      at iterateObserversSafely (node_modules/@apollo/client/utilities/observables/iteration.js:7:25)
      at Object.error (node_modules/@apollo/client/utilities/observables/Concast.js:76:21)
      at notifySubscription (node_modules/zen-observable/lib/Observable.js:140:18)
      at onNotify (node_modules/zen-observable/lib/Observable.js:179:3)
      at SubscriptionObserver.error (node_modules/zen-observable/lib/Observable.js:240:7)
      at handleError (node_modules/@apollo/client/link/http/parseAndCheckHttpResponse.js:170:14)
      at node_modules/@apollo/client/link/http/createHttpLink.js:145:17

    Cause:
    ServerError: Response not successful: Received status code 500

      at Object.throwServerError (node_modules/@apollo/client/link/utils/throwServerError.js:2:17)
      at throwServerError (node_modules/@apollo/client/link/http/parseAndCheckHttpResponse.js:120:9)
      at node_modules/@apollo/client/link/http/parseAndCheckHttpResponse.js:176:48

  ● KyveApi › compare block info

    {"code":-32603,"message":"Internal error","data":"height 4282099 is not available, lowest height is 5823001"}

      342 |   it('compare block info', async () => {
      343 |     const height = 4282099;
    > 344 |     const tendermintBlockInfo = await tendermint.block(height);
          |                                 ^
      345 |     const [kyveBlockInfo] = await kyveApi.getBlockByHeight(height);
      346 |     expect(isEqual(tendermintBlockInfo, kyveBlockInfo)).toBe(true);
      347 |   });

      at HttpClient.execute (node_modules/@cosmjs/tendermint-rpc/src/rpcclients/httpclient.ts:48:13)
      at Tendermint37Client.doCall (node_modules/@cosmjs/tendermint-rpc/src/tendermint37/tendermint37client.ts:346:20)
      at Object.<anonymous> (packages/node/src/utils/kyve/kyve.spec.ts:344:33)

Report generated by 🧪jest coverage report action from 5133262

stwiname · 2024-08-22T20:55:02Z

packages/node/src/utils/cosmos.ts

+        if (BigInt(filter.values[key]) === decodedMsgData) {
+          continue;
+        } else {
+          return false;
+        }


Suggested change

if (BigInt(filter.values[key]) === decodedMsgData) {

continue;

} else {

return false;

}

if (BigInt(filter.values[key]) 1== decodedMsgData) {

return false;

}

The continue statement cannot be removed; otherwise, it will enter the next if statement where no type conversion is performed. It must return false.

yoozo added 2 commits August 22, 2024 07:14

fix-dictionary-bigint

f1b4fb1

unit test

2fc1c4a

stwiname reviewed Aug 22, 2024

View reviewed changes

Merge branch 'main' into fix-dictionary-bigint

5133262

stwiname approved these changes Aug 23, 2024

View reviewed changes

yoozo merged commit cff6854 into main Aug 23, 2024
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix dictionary bigint #281

Fix dictionary bigint #281

yoozo commented Aug 22, 2024 •

edited

Loading

github-actions bot commented Aug 22, 2024 •

edited

Loading

stwiname Aug 22, 2024

yoozo Aug 23, 2024

Fix dictionary bigint #281

Fix dictionary bigint #281

Conversation

yoozo commented Aug 22, 2024 • edited Loading

Description

Type of change

Checklist

github-actions bot commented Aug 22, 2024 • edited Loading

Coverage report

Test suite run failed

stwiname Aug 22, 2024

Choose a reason for hiding this comment

yoozo Aug 23, 2024

Choose a reason for hiding this comment

yoozo commented Aug 22, 2024 •

edited

Loading

github-actions bot commented Aug 22, 2024 •

edited

Loading