Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codegen pathing for protogen #196

Merged
merged 3 commits into from
Nov 8, 2023
Merged

update codegen pathing for protogen #196

merged 3 commits into from
Nov 8, 2023

Conversation

bz888
Copy link
Contributor

@bz888 bz888 commented Oct 31, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Using path.basename is a more consistent on different OS

Fixes #subquery/subql#2115

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 34.27% 1670/4873
🟡 Branches 62.94% 90/143
🔴 Functions 17.84% 33/185
🔴 Lines 34.27% 1670/4873

Test suite run success

37 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from de017a1

@stwiname stwiname merged commit f54fd27 into main Nov 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants