Ethscriptions Example Added #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stwiname
reviewed
Jan 4, 2024
| handlers: [ | ||
| { | ||
| kind: EthereumHandlerKind.Call, | ||
| handler: "handleTransaction", |
There was a problem hiding this comment.
I haven't tested this but if you filter the function this should greatly speed up indexing by being able to use dictionaries.
The function in this case is data: encoded in hex
Suggested change
| handler: "handleTransaction", | |
| handler: "handleTransaction", | |
| filter: { | |
| function: "0x64617461" | |
| } |
There was a problem hiding this comment.
Please test and include if working
jamesbayly
reviewed
Jan 5, 2024
jamesbayly
reviewed
Jan 5, 2024
| dataSources: [ | ||
| { | ||
| kind: EthereumDatasourceKind.Runtime, | ||
| startBlock: 18130011, |
There was a problem hiding this comment.
Why was this start block picked? Comment on any significance?
jamesbayly
reviewed
Jan 5, 2024
| @@ -0,0 +1,6 @@ | |||
| type Inscription @entity { | |||
There was a problem hiding this comment.
Can we add a created: Date! to this
jamesbayly
reviewed
Jan 5, 2024
| block: tx.blockNumber, | ||
| creator: tx.from, | ||
| }); | ||
| inscription.save(); |
There was a problem hiding this comment.
Suggested change
| inscription.save(); | |
| await inscription.save(); |
jamesbayly
reviewed
Jan 5, 2024
| if (!tx.input) { | ||
| return; | ||
| } | ||
| let inscription: Inscription; |
There was a problem hiding this comment.
any reason why this is initialised outside of the below IF?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.