fix: Simplify embedding the Microsoft.TestPlatform.Portable nupkg #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, embedding the `Microsoft.TestPlatform.Portable` NuGet package into Stryker.Core would only happen during an Azure Pipelines run. Now it's done at build time instead, thanks to `GeneratePathProperty` + `$(PkgMicrosoft_TestPlatform_Portable)` which enables locating the restored `Microsoft.TestPlatform.Portable` nupkg file at build time. A new test has also been introduced, making sure that `DeployEmbeddedVsTestBinaries` is successful. Finally, exception messages have been improved. Fixes stryker-mutator#3103
0xced
force-pushed
the
embed-Microsoft.TestPlatform.Portable
branch
from
040b0c1
to
586b973
Compare
|
That is very cool! Thanks! I'll review soon. |
rouke-broersma
changed the title
|
Thanks for merging and releasing version 4.4.1 quickly. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, embedding the
Microsoft.TestPlatform.PortableNuGet package into Stryker.Core would only happen during an Azure Pipelines run. Now it's done at build time instead, thanks toGeneratePathProperty+$(PkgMicrosoft_TestPlatform_Portable)which enables locating the restoredMicrosoft.TestPlatform.Portablenupkg file at build time.A new test has also been introduced, making sure that
DeployEmbeddedVsTestBinariesis successful.Finally, exception messages have been improved.
Fixes #3103