Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add node orchestrator for global statements #3087

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

dupdob
Copy link
Member

@dupdob dupdob commented Oct 28, 2024

Fix issues with global statements, such as handling of stryker comments and complex mutation declarations (block level).
Declare an orchestrator for global statements. For some reason, the GlobalStatementSyntax class inherits from MemberDefinitionSyntax, which does not lead to the expected behavior: Stryker treats Member Definition as hard barriers.
fix #3081
fix #3073

@dupdob dupdob marked this pull request as ready for review November 8, 2024 12:43
Copy link

sonarcloud bot commented Nov 8, 2024

@dupdob
Copy link
Member Author

dupdob commented Nov 8, 2024

Oups. I forgot this PR was still in draft, so I missed merge Friday
Sorry about this.

@rouke-broersma
Copy link
Member

Merge friday, I like it :D

@rouke-broersma rouke-broersma changed the title Add node orchestrator for global statements. fix: Add node orchestrator for global statements Nov 8, 2024
@richardwerkman
Copy link
Member

@dupdob thanks for fixing this! Looks good, I'm just thinking this could be something we want to add to the integration test as well. We currently don't have any top-level statements in the integration test project. But I suggest creating a separate issue for that so we can release this fix quickly (I want to release today). Would you agree?

@dupdob
Copy link
Member Author

dupdob commented Nov 8, 2024

Of course
Makes great sense

@richardwerkman richardwerkman merged commit 96d7c8c into master Nov 8, 2024
9 checks passed
@richardwerkman richardwerkman deleted the fix_stryker_comment branch November 8, 2024 16:39
@cfuehrmann
Copy link

Thanks for fixing this! Looking forward to trying this as soon as I get my hands on the next stryker-net release.

@richardwerkman
Copy link
Member

@cfuehrmann the release is out the door! So you can try it if you want

@cfuehrmann
Copy link

I can confirm from our nightly runs that the issue is indeed fixed. Thanks ever so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stryker messes with compiler directives Stryker disable comment not working for global statements
4 participants