-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add node orchestrator for global statements #3087
Conversation
Quality Gate passedIssues Measures |
Oups. I forgot this PR was still in draft, so I missed merge Friday |
Merge friday, I like it :D |
@dupdob thanks for fixing this! Looks good, I'm just thinking this could be something we want to add to the integration test as well. We currently don't have any top-level statements in the integration test project. But I suggest creating a separate issue for that so we can release this fix quickly (I want to release today). Would you agree? |
Of course |
Thanks for fixing this! Looking forward to trying this as soon as I get my hands on the next stryker-net release. |
@cfuehrmann the release is out the door! So you can try it if you want |
I can confirm from our nightly runs that the issue is indeed fixed. Thanks ever so much! |
Fix issues with global statements, such as handling of stryker comments and complex mutation declarations (block level).
Declare an orchestrator for global statements. For some reason, the GlobalStatementSyntax class inherits from MemberDefinitionSyntax, which does not lead to the expected behavior: Stryker treats Member Definition as hard barriers.
fix #3081
fix #3073