feat: migrate to slog.Logger #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the ServerLogger interface and updates the recover and logging middlewares. Signed-off-by: Marek Cermak <[email protected]>
Signed-off-by: Marek Cermak <[email protected]>
Signed-off-by: Marek Cermak <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 69.78% 62.23% -7.55%
==========================================
Files 8 11 +3
Lines 546 617 +71
==========================================
+ Hits 381 384 +3
- Misses 153 221 +68
Partials 12 12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marek Cermak <[email protected]>
TomasKocman
reviewed
Mar 10, 2024
TomasKocman
reviewed
Mar 10, 2024
TomasKocman
reviewed
Mar 10, 2024
TomasKocman
reviewed
Mar 10, 2024
This commit also removes the error and panic objects from the log data and renames it to request data. The fields are then nested under a group called "request" and as such, "request_" prefix was removed from the fields. Signed-off-by: Marek Cermak <[email protected]>
Signed-off-by: Marek Cermak <[email protected]>
Signed-off-by: Marek Cermak <[email protected]>
Signed-off-by: Marek Cermak <[email protected]>
CermakM
force-pushed
the
feat/migrate-to-slog
branch
from
da2e122
to
13501ff
Compare
TomasKocman
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the ServerLogger interface and updates the recover and logging middlewares.