Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates requested in #15 #18

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Conversation

robertrossmann
Copy link
Member

@robertrossmann robertrossmann commented Apr 10, 2024

Closes #15.

@robertrossmann robertrossmann added the enhancement New feature or request label Apr 10, 2024
@robertrossmann robertrossmann self-assigned this Apr 10, 2024
@robertrossmann robertrossmann requested review from CermakM and a team April 10, 2024 20:04
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.36842% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.57%. Comparing base (1ff5d9f) to head (aa57be5).

Files Patch % Lines
background.go 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   75.00%   81.57%   +6.57%     
==========================================
  Files           6        5       -1     
  Lines         160      152       -8     
==========================================
+ Hits          120      124       +4     
+ Misses         40       28      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertrossmann robertrossmann added this to the v0.1 milestone Apr 11, 2024
Copy link

@CermakM CermakM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments! LGTM 💪

@robertrossmann robertrossmann merged commit 5b317d0 into master Apr 29, 2024
5 checks passed
@robertrossmann robertrossmann deleted the feat/preparation-for-v1 branch April 29, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The road to v0.1 🚀
3 participants