Don't update capabilities concurrently from same host. #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancycode
force-pushed
the
concurrent-capabilities
branch
from
8f1ec78 to
5067fb6
Compare
If capabilities are expired and requested from multiple clients concurrently, this could cause concurrent (duplicate) requests to the same Nextcloud host. With this change, only a single request is sent to Nextcloud in such cases.
fancycode
force-pushed
the
concurrent-capabilities
branch
from
5067fb6 to
147fb23
Compare
Pull Request Test Coverage Report for Build 11256166952Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If capabilities are expired and requested from multiple clients concurrently, this could cause concurrent (duplicate) requests to the same Nextcloud host. With this change, only a single request is sent to Nextcloud in such cases.
Fixes #832
@nickvergessen FYI