Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send ping requests to local instance for federated sessions. #808

Merged
merged 8 commits into from
Aug 29, 2024
Merged

Send ping requests to local instance for federated sessions. #808

merged 8 commits into from
Aug 29, 2024

Conversation

fancycode
Copy link
Member

@coveralls
Copy link

coveralls commented Aug 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10616567159

Details

  • 127 of 153 (83.01%) changed or added relevant lines in 8 files are covered.
  • 15 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.1%) to 58.487%
Changes Missing Coverage Covered Lines Changed/Added Lines %
clientsession.go 12 14 85.71%
room_ping.go 17 20 85.0%
virtualsession.go 5 8 62.5%
session.go 6 10 60.0%
hub.go 66 80 82.5%
Files with Coverage Reduction New Missed Lines %
room_ping.go 1 89.05%
grpc_client.go 2 79.0%
mcu_proxy.go 2 60.78%
clientsession.go 2 67.79%
federation.go 4 78.83%
dns_monitor.go 4 94.12%
Totals Coverage Status
Change from base Build 10610962373: 0.1%
Covered Lines: 10585
Relevant Lines: 18098
💛 - Coveralls

@fancycode fancycode marked this pull request as ready for review August 28, 2024 12:29
@fancycode fancycode mentioned this pull request Aug 29, 2024
Closed
@fancycode
Prefix room session id for sessions that get federated.
b233651 
This allows using a single signaling server with two Nextcloud instances
during development.
nickvergessen
nickvergessen approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully now

@fancycode fancycode merged commit 628642a into master Aug 29, 2024
26 checks passed
@fancycode fancycode deleted the federation-pings branch August 29, 2024 14:04
mwalbeck pushed a commit to mwalbeck/docker-nextcloud-spreed-signaling that referenced this pull request Sep 13, 2024
@mwalbeck
Update dependency strukturag/nextcloud-spreed-signaling to v2 (#504)
906e7de 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [strukturag/nextcloud-spreed-signaling](https://github.com/strukturag/nextcloud-spreed-signaling) | major | `v1.3.2` -> `v2.0.0` |

---

### Release Notes

<details>
<summary>strukturag/nextcloud-spreed-signaling (strukturag/nextcloud-spreed-signaling)</summary>

### [`v2.0.0`](https://github.com/strukturag/nextcloud-spreed-signaling/releases/tag/v2.0.0)

[Compare Source](strukturag/nextcloud-spreed-signaling@v1.3.2...v2.0.0)

##### Added

-   Federation support  [#&#8203;776](strukturag/nextcloud-spreed-signaling#776)
-   CI: Add job to update generated files.  [#&#8203;790](strukturag/nextcloud-spreed-signaling#790)
-   Expose backend session limits through prometheus stats.  [#&#8203;792](strukturag/nextcloud-spreed-signaling#792)
-   CI: Test with Golang 1.23  [#&#8203;805](strukturag/nextcloud-spreed-signaling#805)

##### Changed

-   Keep generated files in the repository.  [#&#8203;781](strukturag/nextcloud-spreed-signaling#781)
-   Improve caching when fetching capabilities.  [#&#8203;780](strukturag/nextcloud-spreed-signaling#780)
-   Enforce a minimum duration to cache capabilities.  [#&#8203;783](strukturag/nextcloud-spreed-signaling#783)
-   docs: Use the latest LTS of Ubuntu and Python 3.12.  [#&#8203;791](strukturag/nextcloud-spreed-signaling#791)
-   CI: Push generated code from service account.  [#&#8203;793](strukturag/nextcloud-spreed-signaling#793)
-   CI: Only build code if token exists (i.e. with Dependabot).  [#&#8203;794](strukturag/nextcloud-spreed-signaling#794)
-   CI: Always do a full build of generated files.  [#&#8203;795](strukturag/nextcloud-spreed-signaling#795)
-   Remove compatibility code for Go < 1.21.  [#&#8203;806](strukturag/nextcloud-spreed-signaling#806)
-   Send ping requests to local instance for federated sessions.  [#&#8203;808](strukturag/nextcloud-spreed-signaling#808)

##### Dependencies

-   Bump sphinx from 7.3.7 to 7.4.4 in /docs  [#&#8203;773](strukturag/nextcloud-spreed-signaling#773)
-   Bump google.golang.org/grpc from 1.64.0 to 1.65.0  [#&#8203;769](strukturag/nextcloud-spreed-signaling#769)
-   Bump sphinx from 7.4.4 to 7.4.5 in /docs  [#&#8203;774](strukturag/nextcloud-spreed-signaling#774)
-   Bump github.com/nats-io/nats-server/v2 from 2.10.17 to 2.10.18  [#&#8203;775](strukturag/nextcloud-spreed-signaling#775)
-   Bump sphinx from 7.4.5 to 7.4.6 in /docs  [#&#8203;777](strukturag/nextcloud-spreed-signaling#777)
-   Bump sphinx from 7.4.6 to 7.4.7 in /docs  [#&#8203;779](strukturag/nextcloud-spreed-signaling#779)
-   Bump the etcd group with 4 updates  [#&#8203;778](strukturag/nextcloud-spreed-signaling#778)
-   Bump golangci/golangci-lint-action from 6.0.1 to 6.1.0  [#&#8203;788](strukturag/nextcloud-spreed-signaling#788)
-   Bump google.golang.org/grpc/cmd/protoc-gen-go-grpc from 1.4.0 to 1.5.1  [#&#8203;784](strukturag/nextcloud-spreed-signaling#784)
-   Bump markdown from 3.6 to 3.7 in /docs  [#&#8203;801](strukturag/nextcloud-spreed-signaling#801)
-   Bump github.com/prometheus/client_golang from 1.19.1 to 1.20.2  [#&#8203;803](strukturag/nextcloud-spreed-signaling#803)
-   Bump golang from 1.22-alpine to 1.23-alpine in /docker/server  [#&#8203;798](strukturag/nextcloud-spreed-signaling#798)
-   Bump golang from 1.22-alpine to 1.23-alpine in /docker/proxy  [#&#8203;799](strukturag/nextcloud-spreed-signaling#799)
-   Bump google.golang.org/grpc from 1.65.0 to 1.66.0  [#&#8203;810](strukturag/nextcloud-spreed-signaling#810)
-   Bump github.com/nats-io/nats-server/v2 from 2.10.18 to 2.10.19  [#&#8203;809](strukturag/nextcloud-spreed-signaling#809)
-   Bump github.com/nats-io/nats.go from 1.36.0 to 1.37.0  [#&#8203;797](strukturag/nextcloud-spreed-signaling#797)
-   Bump mkdocs from 1.6.0 to 1.6.1 in /docs  [#&#8203;812](strukturag/nextcloud-spreed-signaling#812)
-   Bump github.com/nats-io/nats-server/v2 from 2.10.19 to 2.10.20  [#&#8203;813](strukturag/nextcloud-spreed-signaling#813)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4zIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119-->

Reviewed-on: https://git.walbeck.it/walbeck-it/docker-nextcloud-spreed-signaling/pulls/504
Co-authored-by: renovate-bot <[email protected]>
Co-committed-by: renovate-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Federated call ends after some time without a local participant
3 participants
@fancycode @coveralls @nickvergessen