Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for Janus 1.x #669

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Improve support for Janus 1.x #669

merged 1 commit into from
Apr 16, 2024

Conversation

fancycode
Copy link
Member

While Janus 1.x still supports backwards compatible APIs, it would be better to switch to new APIs.

@coveralls
Copy link

coveralls commented Feb 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8067674680

Details

  • -14 of 14 (0.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 53.496%
Changes Missing Coverage Covered Lines Changed/Added Lines %
mcu_janus.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
grpc_client.go 1 76.3%
dns_monitor.go 3 95.93%
Totals Coverage Status
Change from base Build 8067656822: -0.06%
Covered Lines: 7736
Relevant Lines: 14461
💛 - Coveralls

@fancycode fancycode marked this pull request as ready for review April 16, 2024 14:23
@fancycode fancycode merged commit 0aed690 into master Apr 16, 2024
19 checks passed
@fancycode fancycode deleted the janus-multistream branch April 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fancycode @coveralls