Fix deadlock when entry is removed while receiver holds lock in lookup. #654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem happened in CI tests of GrpcClients which tried to remove the entry concurrently with
onLookup
.When trying to remove the entry here:
nextcloud-spreed-signaling/grpc_client.go
Line 755 in c85b31b
The lock was acquired here:
nextcloud-spreed-signaling/grpc_client.go
Line 744 in c85b31b
Concurrently, the DNS monitor was notifying about the lookup here:
nextcloud-spreed-signaling/grpc_client.go
Line 511 in c85b31b
And previously acquired its lock here:
nextcloud-spreed-signaling/dns_monitor.go
Line 64 in c85b31b
Found here:
https://github.com/strukturag/nextcloud-spreed-signaling/actions/runs/7813581057/job/21313022175?pr=653
With this change, removing entries is possible while the lookup results are currently processed.