Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip options from default section when parsing "geoip-overrides". #609

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Skip options from default section when parsing "geoip-overrides". #609

merged 2 commits into from
Dec 8, 2023

Conversation

fancycode
Copy link
Member

Fixes #607

CC @SystemKeeper

@coveralls
Copy link

coveralls commented Dec 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7128228624

  • 22 of 31 (70.97%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 54.666%
Changes Missing Coverage Covered Lines Changed/Added Lines %
config.go 16 18 88.89%
proxy/proxy_tokens_static.go 3 5 60.0%
mcu_proxy.go 0 5 0.0%
Totals Coverage Status
Change from base Build 7127302912: 0.06%
Covered Lines: 7334
Relevant Lines: 13416
💛 - Coveralls

@SystemKeeper
Copy link
Contributor

Tested and works 👍 Thanks!

@fancycode fancycode merged commit 2a16bf0 into master Dec 8, 2023
15 checks passed
@fancycode fancycode deleted the geoip-overrides-default branch December 8, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

main.go:187: Could not create hub: could not parse IP secret/url
3 participants
@fancycode @coveralls @SystemKeeper